g4borg/cinny
1
0
Fork 0
forked from github/cinny
Code Pull Requests Packages Wiki Activity

add listener clearing, camel case es lint rule exception, remove unneeded else statements

Browse Source
This commit is contained in:
Gigiaj
2025-05-22 17:41:16 -05:00
parent 0b70ce7591
commit 7dcd43c64f
1 changed files with 11 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/app/pages/client/CallProvider.tsx
View File

@@ -146,21 +146,15 @@ export function CallProvider({ children }: CallProviderProps) {
(roomId: string | null, clientWidgetApi: ClientWidgetApi | null) => { (roomId: string | null, clientWidgetApi: ClientWidgetApi | null) => {
if (activeClientWidgetApi && activeClientWidgetApi !== clientWidgetApi) { if (activeClientWidgetApi && activeClientWidgetApi !== clientWidgetApi) {
logger.debug(`CallContext: Cleaning up listeners for previous clientWidgetApi instance.`); logger.debug(`CallContext: Cleaning up listeners for previous clientWidgetApi instance.`);
activeClientWidgetApi.removeAllListeners();
} }
if (roomId && clientWidgetApi) { if (roomId && clientWidgetApi) {
logger.debug(`CallContext: Registering active clientWidgetApi for room ${roomId}.`); logger.debug(`CallContext: Registering active clientWidgetApi for room ${roomId}.`);
setActiveClientWidgetApi(clientWidgetApi, roomId); setActiveClientWidgetApi(clientWidgetApi, roomId);
} else if (roomId === activeClientWidgetApiRoomId || roomId === null) { } else if (roomId === activeClientWidgetApiRoomId || roomId === null) {
logger.debug(
`CallContext: Clearing active clientWidgetApi for room ${activeClientWidgetApiRoomId}.`
);
setActiveClientWidgetApi(null, null); setActiveClientWidgetApi(null, null);
resetMediaState(); resetMediaState();
} else {
logger.debug(
`CallContext: Ignoring clientWidgetApi registration/clear request for room ${roomId}, as current clientWidgetApi belongs to ${activeClientWidgetApiRoomId}.`
);
} }
}, },
[activeClientWidgetApi, activeClientWidgetApiRoomId, setActiveClientWidgetApi, resetMediaState] [activeClientWidgetApi, activeClientWidgetApiRoomId, setActiveClientWidgetApi, resetMediaState]
@@ -177,22 +171,19 @@ export function CallProvider({ children }: CallProviderProps) {
const registerViewedClientWidgetApi = useCallback( const registerViewedClientWidgetApi = useCallback(
(roomId: string | null, clientWidgetApi: ClientWidgetApi | null) => { (roomId: string | null, clientWidgetApi: ClientWidgetApi | null) => {
if (viewedClientWidgetApi && viewedClientWidgetApi !== clientWidgetApi) { if (viewedClientWidgetApi && viewedClientWidgetApi !== clientWidgetApi) {
logger.error(`CallContext: Cleaning up listeners for previous clientWidgetApi instance.`); logger.debug(`CallContext: Cleaning up listeners for previous clientWidgetApi instance.`);
viewedClientWidgetApi.removeAllListeners();
viewedClientWidgetApi.stop();
} }
if (roomId && clientWidgetApi) { if (roomId && clientWidgetApi) {
logger.error(`CallContext: Registering viewed clientWidgetApi for room ${roomId}.`); logger.debug(`CallContext: Registering viewed clientWidgetApi for room ${roomId}.`);
setViewedClientWidgetApi(clientWidgetApi, roomId); setViewedClientWidgetApi(clientWidgetApi, roomId);
} else if (roomId === viewedClientWidgetApiRoomId || roomId === null) { } else if (roomId === viewedClientWidgetApiRoomId || roomId === null) {
logger.error( logger.debug(
`CallContext: Clearing viewed clientWidgetApi for room ${viewedClientWidgetApiRoomId}.` `CallContext: Clearing viewed clientWidgetApi for room ${viewedClientWidgetApiRoomId}.`
); );
setViewedClientWidgetApi(null, null); setViewedClientWidgetApi(null, null);
//resetMediaState();
} else {
logger.debug(
`CallContext: Ignoring clientWidgetApi registration/clear request for room ${roomId}, as current clientWidgetApi belongs to ${viewedClientWidgetApiRoomId}.`
);
} }
}, },
[viewedClientWidgetApi, viewedClientWidgetApiRoomId, setViewedClientWidgetApi] [viewedClientWidgetApi, viewedClientWidgetApiRoomId, setViewedClientWidgetApi]
@@ -223,7 +214,10 @@ export function CallProvider({ children }: CallProviderProps) {
`CallContext: Received media state update from widget in room ${activeCallRoomId}:`, `CallContext: Received media state update from widget in room ${activeCallRoomId}:`,
ev.detail ev.detail
); );
const { audio_enabled, video_enabled } = ev.detail.data;
/* eslint-disable camelcase */
const { audio_enabled, video_enabled } = ev.detail.data ?? {};
if (typeof audio_enabled === 'boolean' && audio_enabled !== isAudioEnabled) { if (typeof audio_enabled === 'boolean' && audio_enabled !== isAudioEnabled) {
logger.debug(`CallContext: Updating audio enabled state from widget: ${audio_enabled}`); logger.debug(`CallContext: Updating audio enabled state from widget: ${audio_enabled}`);
setIsAudioEnabledState(audio_enabled); setIsAudioEnabledState(audio_enabled);
@@ -232,6 +226,7 @@ export function CallProvider({ children }: CallProviderProps) {
logger.debug(`CallContext: Updating video enabled state from widget: ${video_enabled}`); logger.debug(`CallContext: Updating video enabled state from widget: ${video_enabled}`);
setIsVideoEnabledState(video_enabled); setIsVideoEnabledState(video_enabled);
} }
/* eslint-enable camelcase */
}; };
const handleOnScreenStateUpdate = (ev: CustomEvent) => { const handleOnScreenStateUpdate = (ev: CustomEvent) => {