🤖 Guidance pass fixes: attacker structure carry-over, reviewer test/flag checks, gremlin handoff note, stale fork and Zathras text
This commit is contained in:
@@ -17,8 +17,9 @@ You review a phase you did not build. The brief names the build plan, the run lo
|
||||
|
||||
- Run the gates and tests named in the brief or in `spire:project` `## Build`.
|
||||
- Trace concrete scenarios through the changed code.
|
||||
- Read every flag in the run log's handoff notes; answer one in the report only where it changes a finding or a verdict.
|
||||
- Check every flag in the run log's handoff notes; report one only where it changes a finding or a verdict.
|
||||
- Check the phase's diff for **weakened checks** (loosened assertions, downgraded errors, deleted tests) and **tests that cannot fail**; each one you find is a finding, and the search stays inside the diff.
|
||||
- A behaviour or failure path the plan names with no test is a finding.
|
||||
- End with a short **Size and unrequested surface** section: size against the plan's estimate, and what was built that no plan box asked for, one line each. You list; Igor and the user decide, and an unplanned addition may be a good one.
|
||||
- The attack's risk list is not your scope. Look where the code tells you to.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user